Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative imports from node_modules are handled incorrectly #100

Closed
nex3 opened this issue Oct 1, 2019 · 0 comments
Closed

Relative imports from node_modules are handled incorrectly #100

nex3 opened this issue Oct 1, 2019 · 0 comments
Assignees
Labels
bug Something isn't working module system Part of the module system migrator

Comments

@nex3
Copy link
Contributor

nex3 commented Oct 1, 2019

Currently, if a file imported through node_modules contains a relative import, that relative URL is used as-is in referencing files:

<==> input/entrypoint.scss
@import "~module/dependency";

a {
  color: $variable;
}

<==> input/node_modules/module/_dependency.scss
@import "other";

<==> input/node_modules/module/_other.scss
$variable: green;

This should produce @use "~module/other", but it currently produces @use "other" which is just broken.

@nex3 nex3 added bug Something isn't working module system Part of the module system migrator labels Oct 1, 2019
@nex3 nex3 self-assigned this Oct 1, 2019
@nex3 nex3 added this to To do in Module system via automation Oct 1, 2019
@nex3 nex3 moved this from To do to In progress in Module system Oct 1, 2019
@nex3 nex3 closed this as completed in 5eec0d8 Oct 1, 2019
Module system automation moved this from In progress to Done Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module system Part of the module system migrator
Projects
Module system
  
Done
Development

No branches or pull requests

1 participant