Marshaling methods for ImportNode, fixes #1028 #1029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith sass-rails (and other undumpable importers)
|
+1 for merge |
|
👍 |
|
It actually doesn't seem to fix it now that I'm running it in my full app rather than in my test harness. Second patch incoming :) |
…to strip out all the inherited methods
|
Will do. |
|
It looks like this isn't the right fix for #1028 after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds
_dumpand::loadmethods for ImportNode, which avoids dumping the@optionsinstance variable, which may be undumpable for reasons external to Sass. For example, sass-rails has anonymous classes and Hashes with default procs, neither of which can be marshaled, and prevents sass from doing its caching work.