Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Rule: Color Variables #27

Closed
Snugug opened this issue Aug 28, 2015 · 4 comments
Closed

New Rule: Color Variables #27

Snugug opened this issue Aug 28, 2015 · 4 comments
Labels
rule
Milestone
1.2.0

Comments

@Snugug
Copy link
Member

Snugug commented Aug 28, 2015

As per SCSS Lint
@Snugug Snugug added the rule label Aug 28, 2015
@DanPurdy
Copy link
Member

DanPurdy commented Sep 3, 2015

Looking at this one.

@DanPurdy
Copy link
Member

DanPurdy commented Sep 3, 2015

So... I have a question about this one. We are going to need to check each value against a list of all the css colors, I'm feeling like this should be a seperate text or yaml file ala scss-lints property listings. Any preference to how we do this?

@DanPurdy DanPurdy added this to the 1.2.0 milestone Sep 4, 2015
@DanPurdy
Copy link
Member

DanPurdy commented Sep 4, 2015

Went with separate YAML file.. will open PR soon, just a little more testing.

@DanPurdy
Copy link
Member

DanPurdy commented Sep 4, 2015

Ready to go just waiting for @bgriffith to fix his conflicts on #81 then I'll get the PR rolling.

@DanPurdy DanPurdy mentioned this issue Sep 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rule
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@Snugug @DanPurdy