-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Rule: Duplicate Property #28
Comments
Will take a look at this one today. |
Any opinions on whether this should trigger when using both long hand and short hand properties? Should the following trigger an error? .foo {
margin-left: 10px;
padding: 0;
margin: 0;
} |
I reckon it should because you are technically duplicating it there it's just sort of hidden from you, in that instance your margin-left value is being overwritten?
|
I've checked out the way SCSS Lint works, and they don't cause an error as technically they are different properties. Maybe this could be a different rule?
|
Makes sense to me, maybe that would actaully be preferable so we can keep the rules fairly granular. |
Since this is only ever disallowing (as you wouldn't ever be enforcing duplicate properties), I think it should follow the current convention for 'disallows' and call it |
As Per SCSS Lint
The text was updated successfully, but these errors were encountered: