Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent rule name (url-format vs no-url-protocols) #335

Closed
mik01aj opened this issue Oct 20, 2015 · 4 comments
Closed

Inconsistent rule name (url-format vs no-url-protocols) #335

mik01aj opened this issue Oct 20, 2015 · 4 comments
Labels
bug

Comments

@mik01aj
Copy link

mik01aj commented Oct 20, 2015

The no-url-protocols rule has another name in the code:

screenshot 2015-10-20 16 21 46

https://github.com/sasstools/sass-lint/blob/bd5861fcee211591cf8adf9c10495f544a84c26f/lib/rules/no-url-protocols.js

This means that no-url-protocols setting in the config is ignored, and url-format will be respected. This is not what the docs say.
@mik01aj mik01aj changed the title Inconsistent rule name Inconsistent rule name (url-format vs no-url-protocols) Oct 20, 2015
@bgriffith bgriffith added the bug label Oct 20, 2015
@bgriffith
Copy link
Member

Thanks, good catch.

@bgriffith bgriffith mentioned this issue Oct 20, 2015
Merged
@bgriffith
Copy link
Member

OK PR pushed, thanks again.

@bgriffith bgriffith mentioned this issue Oct 20, 2015
Merged
@mik01aj
Copy link
Author

mik01aj commented Oct 20, 2015

👍

@DanPurdy
Copy link
Member

Ooops, I actually noticed this the other night and meant to fix it up.. Thanks @mik01aj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DanPurdy @bgriffith @mik01aj