space-around-operator incorrectly enforces negative z-index

[Dru89]

It looks like space-around-operator's exception handling is missing some cases where negative numbers don't necessarily have a dimension or percentage. For instance, the following should be valid CSS:

.foo {
  z-index: -1;
}

Unfortunately, it looks like the space-around-operator rule expects that - to have a space before it. Putting a space before it actually breaks the AST, though.

[alfaproject]

Indeed, noticed this today and was going to report it.

[Dru89]

There are some other scenarios where you can run into this, too, like the expression:

.foo {
  margin: -1 * ($foo + $bar + $baz);
}

[benthemonkey]

Confirmed. Was able to reproduce with the examples above.

This rule isn't about including units, so maybe we don't need to do the check that a value is followed by a dimension or a percent sign? https://github.com/sasstools/sass-lint/blob/develop/lib/rules/space-around-operator.js#L51

[bgriffith]

Thanks for the report. I'm sure there was a reason at looking for units around manipulating the parser. I'll try and have a look at it today and hotfix it.

[SimonFinney]

@bgriffith Is there any updates on this issue?

[bgriffith]

@SimonFinney Thanks for the prod. I've pushed a PR to develop. Hopefully we can do a release this week.

[SimonFinney]

👍