Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: One declaration per line has issue with named parameters #51

Closed
bgriffith opened this issue Aug 30, 2015 · 5 comments
Closed

Bug: One declaration per line has issue with named parameters #51

bgriffith opened this issue Aug 30, 2015 · 5 comments
Milestone

Comments

@bgriffith
Copy link
Member

Named parameters cause issue with one declaration per line. Best example for these are the Other color functions with their optional parameters

The following tests currently fail:

// The following all cause issues
$foo: adjust-color(rgb(255, 0, 0), $lightness: -20%);

.bar {
  color: adjust-color(#102030, $blue: 5);
  background-color: scale-color(hsl(120, 70%, 80%), $lightness: 50%);
  border-color: change-color(hsl(25, 100%, 80%), $lightness: 40%, $alpha: 0.8);
}

Using v1.0.0

@Snugug
Copy link
Member

Snugug commented Aug 30, 2015

If you keep finding and closing these issues, I'm may just make you a collaborator (if you're interested)

@bgriffith
Copy link
Member Author

Sure - sounds good but just glad to help! Working on a fix for this - should be sorted soon. Just ignoring if parent is an argument.

@Snugug
Copy link
Member

Snugug commented Aug 30, 2015

Yup, that's what I'm thinking too.

@Snugug Snugug added this to the 1.0.1 milestone Aug 30, 2015
@Snugug
Copy link
Member

Snugug commented Aug 30, 2015

@bgriffith You've been added as a collaborator! Please continue to issue PRs to update code, but other than that you've just gotta accept the invite!

@bgriffith
Copy link
Member Author

Awesome thanks! Will do. PR up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants