Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules explicitly turned off if not listed ESLint style #58

Closed
lozandier opened this issue Aug 31, 2015 · 2 comments
Closed

Rules explicitly turned off if not listed ESLint style #58

lozandier opened this issue Aug 31, 2015 · 2 comments

Comments

@lozandier
Copy link

It's not clear if rules not present in sass-lint.yml files are turned off automatically (ESLint 1.0 style) or not.

With early runs of gulp-sass-lint, that does not seem to be the case; for codebases that have both Sass & SCSS litn files, it seems there's issues propagating from gonzales-pe unless trailing-semicolon is explicitly set to 0 rather than merely omitting the rule altogether:

screen shot 2015-08-30 at 10 15 14 pm

Seemingly any rule not listing in the sass-lint.yml should be turned off (severity of 0) since that's the clearest way for users of the plugin-in to communicate they are not concerned of that rule being applied to their codebase.

Overtime, it can be more work for them to apply rules they don't care about in their codebase than the rules they care about as rules become simultaneously more useful & complex.

@Snugug Snugug changed the title Enhancement: Rules perhaps should be explicitly stated to be turned off or on if not listed ESLint style Rules explicitly turned off if not listed ESLint style Aug 31, 2015
@Snugug
Copy link
Member

Snugug commented Aug 31, 2015

I originally had it so that user config overrode the default configuration instead of merging, but found that if someone only wanted to change indentation, for instance, they needed to be explicit with their whole configuration.

One option is to not have anything configured by default. Other thoughts?

@lozandier
Copy link
Author

That sounds very sensical to me actually; for the ESLint-style behavior, perhaps it's a flag?

I see this project taking off fast and that can be a pretty dramatic change of behavior all of a sudden…

@Snugug Snugug added this to the 1.2.0 milestone Aug 31, 2015
@Snugug Snugug self-assigned this Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants