Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url-quotes rule should point to the character after the opening paren of url(...) #712

Closed
sompylasar opened this issue May 15, 2016 · 3 comments
Labels

Comments

@sompylasar
Copy link

What version of Sass Lint are you using?

sass-lint@1.7.0
linter-sass-lint@1.5.0 for Atom

Please include any relevant parts of your configuration

url-quotes: 1

What did you do? Please include the actual source code causing the issue.

  background: #ffffff url(./img/image.jpg) center center;

What did you expect to happen?

The error position points to either the first character after the opening paren (the dot '.'):

  background: #ffffff url(./img/image.jpg) center center;
                          ^

or to the whole paren contents, if range is possible:

  background: #ffffff url(./img/image.jpg) center center;
                          ^^^^^^^^^^^^^^^

What actually happened? Please include any error messages given to you by Sass Lint.

The error position points to letter 'g' in '.jpg':

  background: #ffffff url(./img/image.jpg) center center;
                                        ^
  60:41  warning  Quotes around URLs are required  url-quotes

If you're using a IDE plugin have you tried the CLI too?

I tried webpack plugin, https://github.com/alleyinteractive/sasslint-webpack-plugin – no difference.

@bgriffith
Copy link
Member

Thanks for the report! I think this is valid and it's super easy to fix 👍

@DanPurdy
Copy link
Member

Hmm this should of closed when #713 was merged..

@sompylasar
Copy link
Author

@bgriffith @DanPurdy Thanks! When do you think this will get to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants