BEM Depth issue with intepolated placeholder

[nicolas-goudry]

Hello,

There's an issue with bem-depth rule. I manually configured sass-lint, here is my config.

The error is happening because function is trying to split a null value. Here is the stack trace:

C:\react-poc\node_modules\sass-lint\lib\rules\bem-depth.js:12
  var elements = str.split('__').length;
                    ^

TypeError: Cannot read property 'split' of null
    at bemDepth (C:\react-poc\node_modules\sass-lint\lib\rules\bem-depth.js:12:21)
    at Node.<anonymous> (C:\react-poc\node_modules\sass-lint\lib\rules\bem-depth.js:37:17)
    at C:\react-poc\node_modules\gonzales-pe\lib\gonzales.js:305:54
    at Node.traverse (C:\react-poc\node_modules\gonzales-pe\lib\gonzales.js:279:6)
    at Node.traverse (C:\react-poc\node_modules\gonzales-pe\lib\gonzales.js:284:36)
    at Node.traverse (C:\react-poc\node_modules\gonzales-pe\lib\gonzales.js:284:36)
    at Node.traverse (C:\react-poc\node_modules\gonzales-pe\lib\gonzales.js:284:36)
    at Node.traverseByTypes (C:\react-poc\node_modules\gonzales-pe\lib\gonzales.js:304:11)
    at Object.module.exports.detect (C:\react-poc\node_modules\sass-lint\lib\rules\bem-depth.js:29:9)
    at C:\react-poc\node_modules\sass-lint\index.js:124:27
    at Array.forEach (native)
    at Function.sassLint.lintText (C:\react-poc\node_modules\sass-lint\index.js:123:11)
    at C:\react-poc\node_modules\sass-lint\index.js:222:23
    at Array.forEach (native)
    at Function.sassLint.lintFiles (C:\react-poc\node_modules\sass-lint\index.js:219:12)
    at lint (C:\react-poc\node_modules\sasslint-webpack-plugin\lib\linter.js:18:25)

This is happening with a sass-lint test file: sass-lint/tests/sass/placeholder-name-format.sass and rule is at line 57:

%#{$var}
  content: ''

Thanks for this great work anyway, I removed the rule from config for now and it's working as expected!

[DanPurdy]

What version of sass-lint?

[nicolas-goudry]

It's latest 1.8.2

[nicolas-goudry]

Forgot to mention that I use it with sasslint-webpack-plugin, but doesn't seem to be related.

[DanPurdy]

@nicolas-goudry thanks for this, I've finally found some time to look into it and I've found the problem. It'll be fixed in the next version we release.

[nicolas-goudry]

Cool to hear that, we will be able to use it next time you release 😄 ! Thanks a lot !