Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix string interpolation in class names during class-name-format validation #988

Closed
sormy opened this issue Dec 30, 2016 · 2 comments
Closed

Comments

@sormy
Copy link

sormy commented Dec 30, 2016

What version of Sass Lint are you using?

1.9.1

Please include any relevant parts of your configuration

rules:
  class-name-format: [2, { convention: strictbem } ]

What did you do? Please include the actual source code causing the issue.

$primary-class: 'bla-bla-bla';

.#{$primary-class}--small {
  ...

  &__child {
    ...
  }
}

What did you expect to happen?

No error.

What actually happened? Please include any error messages given to you by Sass Lint.

[sass-lint] Class '.--small' should be written in BEM (Block Element Modifier) format
False positive error. Class name should be 'bla-bla-bla--small' and should pass BEM class name validation.

If you're using a IDE plugin have you tried the CLI too?

IDE Plugin, VS Code

@DanPurdy
Copy link
Member

DanPurdy commented Jan 3, 2017

We don't compile your Sass to check for things like this. The only option we have is to ignore interpolation and make sure that the remaining text passes a sort of validation here.

@DanPurdy
Copy link
Member

DanPurdy commented Oct 3, 2017

Released in 1.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants