Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All data uploaded in root cache (empty layer caches) on Windows #87

Closed
rcowsill opened this issue Dec 8, 2020 · 0 comments · Fixed by #89
Closed

All data uploaded in root cache (empty layer caches) on Windows #87

rcowsill opened this issue Dec 8, 2020 · 0 comments · Fixed by #89
Labels
bug Something isn't working

Comments

@rcowsill
Copy link
Contributor

rcowsill commented Dec 8, 2020

Describe the bug
In jobs running on windows, the code that splits out the layers into separate caches is bypassed. All the layer content is left in the root cache. Separated layer caches are created, but each one only contains an empty folder.

To Reproduce
Can be seen in the CI workflow of this repo.

The root cache is 96MB:
https://github.com/satackey/action-docker-layer-caching/runs/1515471574?check_suite_focus=true#step:6:83

Notice that all the layer caches are 30 bytes:
https://github.com/satackey/action-docker-layer-caching/runs/1515471574?check_suite_focus=true#step:6:132

Expected behavior
Layer files are moved out of the root cache and saved in their own layer cache.

Runner Environment (please complete the following information):

  • OS: Microsoft Windows Server 2019 10.0.17763 Datacenter
  • Action version: v0.0.10

Additional context
It looks like this is caused by the \ directory separators used on Windows. recursive-readdir returns paths with \ on Windows, but moveLayerTarsInDir expects /.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant