Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tools module to Python 3 #134

Open
satanas opened this issue Feb 12, 2020 · 2 comments
Open

Migrate tools module to Python 3 #134

satanas opened this issue Feb 12, 2020 · 2 comments
Assignees
@LuisAlejandro
Labels
an:enhancement Improving an existing feature for:python-3-migration Tasks associated with the migration to Python 3 is:good-to-start Good for newcomers and people that want to get familiar with the project

Comments

@satanas
Copy link
Owner

satanas commented Feb 12, 2020 •
edited

https://github.com/satanas/libturpial/blob/development/libturpial/common/tools.py

This change should:

  • Migrate the existing code to python 3
  • Add more tests to cover functionality (if necessary)
  • Ensure previous tests pass locally
@satanas satanas added an:enhancement Improving an existing feature for:python-3-migration Tasks associated with the migration to Python 3 is:good-to-start Good for newcomers and people that want to get familiar with the project labels Feb 12, 2020
@LuisAlejandro
Copy link

Hi @satanas, I would like to take this issue. I will be sending a PR shortly.

@satanas
Copy link
Owner Author

satanas commented Feb 12, 2020

Hey @LuisAlejandro, I just assigned the ticket to you. Thanks for collaborating! 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LuisAlejandro LuisAlejandro

Labels
an:enhancement Improving an existing feature for:python-3-migration Tasks associated with the migration to Python 3 is:good-to-start Good for newcomers and people that want to get familiar with the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@satanas @LuisAlejandro