Breaking Change regarding the usage of vscode-ripgrep

[alexdima]

Hi,

I'm working on VSCode and I am trying to enable the usage of ASAR for VSCode. This can improve the startup time of VSCode by up to 5%. We are at a point where we are pursuing even such small gains...

I have found that your extension makes an assumption about the disk layout of VSCode's node_modules:

satokaz.vscode-memo-life-for-you/out/src/extension.js:396
  const rgPath = path.normalize(path.join(vscode.env.appRoot, "node_modules", "vscode-ripgrep", "bin", "rg"));
satokaz.vscode-memo-life-for-you/out/src/extension.js:733
  grepcmd: (process.platform == "win32") ? "grep -nH ${PATTERN} ${FILES}" : path.normalize(path.join(vscode.env.appRoot, "node_modules", "vscode-ripgrep", "bin", "rg").replace(/\s/g, '\\ ')) + ' -n --no-heading -S ${PATTERN} ${FILES}',
satokaz.vscode-memo-life-for-you/out/src/extension.js:752
  return path.normalize(path.join(vscode.env.appRoot, "node_modules", "vscode-ripgrep", "bin", "rg"));

To make your extension entirely compatible with a distribution of VSCode that uses ASAR, and to make your extension work with both VSCode stable and VSCode insiders, you will need to try to look for rg in two different paths... Something like the following:

const possiblePath1 = path.join(vscode.env.appRoot, "node_modules", "vscode-ripgrep", "bin", "rg")
const possiblePath2 =path.join(vscode.env.appRoot, "node_modules.asar.unpacked", "vscode-ripgrep", "bin", "rg") 

I plan to release the changes to Insiders this week, such that the Insiders build on Friday, 23.02.2018, will contain the ASAR packing of node modules. In the meantime, I have created custom builds that include this change if you wish to test your extension against a VSCode version which contains these changes:

• Win 64
• Win 32
• macOS
• Linux 64
• Linux 32

[satokaz]

@alexandrudima

Thank you for letting me knowing that ASAR will be adopted.

Fixed in #28