Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open to PR for Linux support? #59

Closed
khanlou opened this issue Jun 30, 2022 · 1 comment · Fixed by #60
Closed

Open to PR for Linux support? #59

khanlou opened this issue Jun 30, 2022 · 1 comment · Fixed by #60

Comments

@khanlou
Copy link
Contributor

khanlou commented Jun 30, 2022

I want to use this library on Linux, but it needs a few changes. First, it needs to conditionally import FoundationNetworking, and second, the stringEncoding seems to not work on Linux.

If you're open to it, I can open a PR to address these issues and make the library work on Linux?
@khanlou khanlou mentioned this issue Jul 4, 2022
Merged
@khanlou
Copy link
Contributor Author

khanlou commented Jul 25, 2022

Unfortunately, some of the changes in the PR right before mine (namely in commit cea13a7) broke Linux support. We can fix it, but it seems like we should also maybe add a github action that compiles the library in a linux environment to ensure that future changes don't break linux support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Linux support khanlou/OpenGraph
1 participant
@khanlou