New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🇫🇷 french version for this awesome tutorial #7
Conversation
Thank you!! This is amazing! I won't have time to look into internationalization until the week after next, so I'm going to leave this PR open until then.
I like how you've made this a separate page, but I also want to evaluate a few more I18N solutions. I'm just worried if I make future updates to the English version, I don't want to break any of the translated pages! :) Will revisit this soon. Thank you so much for this contribution! |
awesome site thanks!!! |
…changes more visible, also restore package-lock.json
Merci @kevin-btc! I've never made edits to a PR before, so I followed this guide. I didn't realize it would make changes to your branch directly, so I apologize for that. Regarding this PR, I believe you have a linter or an auto formatter that introduced a lot of styling changes. I'm open to that and hope to set up a linter in the code base at some point, but your diff made it very hard to see the actual code changes. I ended up reverting a lot of the changes made to the I ran this locally and it all looks wonderful to me! Going to merge now. Thank you for your hard work doing the translation and for the updates to link to the French version from the main index. I really appreciate it! |
thank you @felipebrunet! Feel free to make a PR with a |
Great, I'll do it that way. Will send the PR in a few hours. Thanks! |
Oh sorry if it was hard to see the code changes due to my linter ! i didn't pay attention to that. Thank you so much for adding the translation to your website ! it's awesome. |
I made a french version of your tuto because it's very easy to understand the basic of bitcoin for beginner but in France many people don't read English.
What i did :