Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🇫🇷 french version for this awesome tutorial #7

Merged
merged 5 commits into from Nov 14, 2022

Conversation

kevin-btc
Copy link
Contributor

I made a french version of your tuto because it's very easy to understand the basic of bitcoin for beginner but in France many people don't read English.

What i did :

  • Simply translate the english text to french
  • Added a button in the header to change the language

@satsie
Copy link
Owner

satsie commented Oct 20, 2022

Thank you!! This is amazing! I won't have time to look into internationalization until the week after next, so I'm going to leave this PR open until then.

Ideally I'd like to have a selection area where the user can pick their language. EDIT: I see you added a button! Let me checkout the changes, run them locally and do a spot check.

I like how you've made this a separate page, but I also want to evaluate a few more I18N solutions. I'm just worried if I make future updates to the English version, I don't want to break any of the translated pages! :)

Will revisit this soon. Thank you so much for this contribution!

@felipebrunet
Copy link
Contributor

awesome site thanks!!!
I will translate it to spanish right away (and test it on my site in the meantime), as soon as I finish it I'll send you the translated html and point the tutorial to your website.

@satsie
Copy link
Owner

satsie commented Nov 14, 2022

Merci @kevin-btc! I've never made edits to a PR before, so I followed this guide. I didn't realize it would make changes to your branch directly, so I apologize for that.

Regarding this PR, I believe you have a linter or an auto formatter that introduced a lot of styling changes. I'm open to that and hope to set up a linter in the code base at some point, but your diff made it very hard to see the actual code changes. I ended up reverting a lot of the changes made to the gulpfile and main.less. I also restored the build directory because I still have an s3 job that I believe is reading from this (though in theory, everything should be built on the fly and deployed from the deploy directory).

I ran this locally and it all looks wonderful to me! Going to merge now. Thank you for your hard work doing the translation and for the updates to link to the French version from the main index. I really appreciate it!

@satsie satsie merged commit faba5d7 into satsie:master Nov 14, 2022
@satsie
Copy link
Owner

satsie commented Nov 15, 2022

thank you @felipebrunet! Feel free to make a PR with a .html file, similar to what kevin-btc did with fr.html. I am happy to make sure it gets added to the available languages.

@felipebrunet
Copy link
Contributor

Great, I'll do it that way. Will send the PR in a few hours. Thanks!

@kevin-btc
Copy link
Contributor Author

Oh sorry if it was hard to see the code changes due to my linter ! i didn't pay attention to that. Thank you so much for adding the translation to your website ! it's awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants