Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The didTapCheckBox and animationDidStopCheckBox events where renamed #2

Closed
mrbiggred opened this issue Jul 27, 2023 · 1 comment
Closed
Assignees
Labels
breaking Breaking changes
Milestone

Comments

@mrbiggred
Copy link
Member

When converting the project to Swift the BEMCheckBox events where renamed:

  • didTapCheckBox to didTap
  • animationDidStopCheckBox to animationDidStop

Need to decide if I should keep the new names or switch back to the old ones. If I keep the new names I will need to the update the documentation as it still references the old names.

See the Classes/BEMCheckBox.swift file and compare it to the deleted Classes/BEMCheckBox.h.

@mrbiggred mrbiggred added the enhancement New feature or request label Jul 27, 2023
@mrbiggred mrbiggred added this to the v1.5.0 milestone Jul 27, 2023
@mrbiggred mrbiggred self-assigned this Jul 27, 2023
@mrbiggred mrbiggred added this to To do in Saturday MP Overview via automation Jul 27, 2023
@mrbiggred
Copy link
Member Author

Decided to keep the new names but updated the documentation. Fixed by #5.

Saturday MP Overview automation moved this from To do to Done Aug 3, 2023
@mrbiggred mrbiggred added breaking Breaking changes and removed enhancement New feature or request labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
No open projects
Development

No branches or pull requests

1 participant