Remember instances for annotated entities too

[jivimberg]

This solves issues: #215 and #243 as well as #185.
Basically I'm using a Map with weak keys to keep track of the row ID for a given object instance. In the past the id field was used for the entities that extend SugarRecord, but that's not possible for annotated entities.

[whoshuu]

I'm going to take a look at this tomorrow. This is a pretty big bug that should be fixed!

[jivimberg]

The fix is pretty straightforward. The only thing is that I had to add the Guava dependency to create the concurrent map with weak keys to avoid a memory leak.
Let me know if I can be of any help.

[whoshuu]

I'm close to merging this in, but it's failing an important case:

Model model = new Model("Test");
long id = SugarRecord.save(model);
Model query = SugarRecord.findById(Model.class, 1);
assertEquals(id, new Long(query));

The expectation is that the queried model retains the id from the original, but Java sees model and query as different objects. One was created by the user, the other was inflated by Sugar.

[sibelius]

@jivimberg do you have any ideia of how to remove guava dependency?

Another problem is that MapMaker is deprecated (https://github.com/google/guava/wiki/MapMakerMigration)

is there no way to fix this issue without using a Map?

[jivimberg]

It seams that the MapMaker call can be replaced by a CacheBuilder which still has the option of specifying weakKeys

[sibelius]

@jivimberg the problem with CacheBuilder is that it has guava dependency that make the size of this lib bigger, can we just add part of guava ?

[jivimberg]

Oh! I see. I guess we could easily take a look at the CacheBuilder implementation. The key thing here is to have weak reference for the keys in the map so we don't run into a memory leak