Added support to instant run #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @bendaniel10 and @nurolopher to be potential reviewers |
This was referenced Apr 2, 2016
Closed
Closed
|
@firasalkafri I will take a look tomorrow (Monday), thanks |
|
@firasalkafri could you solve the conflict? I will take a look to your code if solved this. |
|
@JonatanSalas I don't see any conflicts :/ |
|
@JonatanSalas now I see it, resolved. |
|
@firasalkafri could you rebase your commits? |
…rName can also throw LinkageError and ExceptionInInitializerError. If we silently ignore a ClassNotFoundException, I don't see why we wouldn't ignore the others. A NoClassDefFoundError coming out of this method was causing my application to crash, but it was actually fine that the class couldn't be loaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a headache to all of us using the new Android Studio with Instant Run feature
Added a few statements to read dex names and paths in the newly created instant-run directory when using the Instant Run feature inside the already existing method
getSourcePaths.which is called by also the already existing methodgetAllClasses