Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub Actions #85

Closed
christian-bromann opened this issue Sep 19, 2020 · 8 comments · Fixed by #87
Closed

Move to GitHub Actions #85

christian-bromann opened this issue Sep 19, 2020 · 8 comments · Fixed by #87
Labels
Hacktoberfest Curated issues which are well scoped and ready to be worked on as part of Hacktoberfest help wanted Extra attention is needed

Comments

@christian-bromann
Copy link
Contributor

With GitHub Actions being better integrated into GitHub it makes sense to get rid of TravisCI and run all our tests here.

@christian-bromann christian-bromann added help wanted Extra attention is needed Hacktoberfest Curated issues which are well scoped and ready to be worked on as part of Hacktoberfest labels Sep 28, 2020
@abskmj
Copy link
Contributor

abskmj commented Oct 1, 2020

@christian-bromann I can pick this up. I have written GitHub actions based workflows for a few of my npm packages.

@christian-bromann
Copy link
Contributor Author

Awesome, let me know if you need anything.

@abskmj
Copy link
Contributor

abskmj commented Oct 1, 2020

Thanks!

Currently, ./bin/speedo run http://www.saucedemo.com -n "Speedo CI Build" step is failing with the below error. I can set up the workflow to take them from the Github secrets. How do I get the values for testing purposes?

Your Sauce credentials are missing!
Either set 'SAUCE_USERNAME' and 'SAUCE_ACCESS_KEY' in your environment or
provide them as parameter

@christian-bromann
Copy link
Contributor Author

@abskmj this is something I can setup, can you test with a temporary account to see if the pipeline runs through and then just submit a PR?

@abskmj
Copy link
Contributor

abskmj commented Oct 1, 2020

I was able to create a temporary account and check the pipeline. Now, it is going through. Thanks.

I have a question about the deploy step. When exactly does it run, does it only when you create a tag?

deploy:
  provider: script
  script: "npm install && npm run docker"
  on:
    tags: true

@christian-bromann
Copy link
Contributor Author

does it only when you create a tag?

Yes.

@abskmj
Copy link
Contributor

abskmj commented Oct 1, 2020

I have raised a pull request #87 with related changes. I have added 2 workflows,

  • one to run test cases when new code is pushed on any branch or a pull request is created on any branch.
  • other to build and push docker images when a new tag is pushed.

@christian-bromann
Copy link
Contributor Author

Awesome, let's continue our conversations there.

@christian-bromann christian-bromann linked a pull request Oct 1, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Curated issues which are well scoped and ready to be worked on as part of Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants