Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license? #1

Closed
miekg opened this issue Jul 15, 2012 · 10 comments
Closed

license? #1

miekg opened this issue Jul 15, 2012 · 10 comments

Comments

@miekg
Copy link
Contributor

miekg commented Jul 15, 2012

What is the license for this code? I forked it and made (large) bunch of changes...

@sauerbraten
Copy link
Owner

No idea, actually. I never had a deeper look into licenses. I did a quick comparison and for now I'll put it under MIT License. I'll update the README, thanks for bringing this up. Also, do you want me to add you as a collaborator so you can merge your changes? I had a quick look on them and they all seem to make sense. I don't know why you deleted the README, though?

@miekg
Copy link
Contributor Author

miekg commented Jul 15, 2012

I would recommand the same license as the official Go code and make it copyrighted by you.
you can indeed merge my changes.

I also removed your README as I thought all the relevant doc should be in the go file, but you can ofcourse not merge that change :-)

@miekg
Copy link
Contributor Author

miekg commented Jul 15, 2012

I also renamed the repo to radix (and the package)

@sauerbraten
Copy link
Owner

May I ask why you recommend the Go BSD license? It sounds more elaborate, but is that needed?

@miekg
Copy link
Contributor Author

miekg commented Jul 15, 2012

not sure, compatibility with the Go license might be worth while (maybe this stuff can one day be added to the official Go repos)

@sauerbraten
Copy link
Owner

alright it uses the go license now, without the "no advertising with google inc.'s name" part, though.

@miekg
Copy link
Contributor Author

miekg commented Jul 15, 2012

Cool. I re-added your readme

@sauerbraten
Copy link
Owner

so how do I merge your changes? or can you, as a collaborator?

@miekg
Copy link
Contributor Author

miekg commented Jul 15, 2012

I don't know? What do you want? Me and you as authors/collaborators. I'm cool with that, if you are too?

I can send you a pull request with my current code?

@sauerbraten
Copy link
Owner

yup, you're collaborator on the original repo (which I'll rename to radix) and both of us authors in the license, ok?
and yes, I think I can merge a pull request, let's try :D

@miekg miekg closed this as completed Jul 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants