Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gulp from dependency #7

Open
tnguyen14 opened this issue Jun 30, 2017 · 2 comments
Open

Remove gulp from dependency #7

tnguyen14 opened this issue Jun 30, 2017 · 2 comments

Comments

@tnguyen14
Copy link

Can gulp be moved to devDependency? Or spin the icon sprite inject gulp task into a separate repo? I'd like to use this, but don't want to pull gulp into my project.

@saulhoward
Copy link
Owner

Hi @tnguyen14 -- it's a good question, I agree that gulp shouldn't be a dependency.

Unfortunately, the current design uses gulp to build and inject the SVG 'sprites'. I would like to move to a different design (probably building the icons as separately importable React components). Hopefully I will get round to this soon, I just haven't been able to spare the time.

If you can suggest another way, please do send me a PR, and I'll definitely take a look.

@tnguyen14
Copy link
Author

There are many ways the sprite can be included into the HTML, and gulp is just one. It is not very useful for projects that don't use gulp.

I think that instead of including gulp in this project, you should just add the task as part of the documentation as a suggestion for how the icon sprite could be injected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants