Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/priecing sauna #49

Merged
merged 28 commits into from Apr 29, 2022
Merged

Feature/priecing sauna #49

merged 28 commits into from Apr 29, 2022

Conversation

TG134516
Copy link
Contributor

Summary

Implementation of all required methods for price structure

Related Issues

Definition of Done

  • User story
    • All stated conditions fulfilled
  • Code
    • No more code needed
    • No known bugs
  • Clean Code
    • JavaDoc has been added
    • API documentation has been added via annotations (if applicable)
    • No unavoidable code smells
  • Testing
    • All existing tests pass
    • New unit tests created according to CONTRIBUTING.md
    • New unit tests pass
  • SonarCloud
    • Quality gate passed
  • Compatibility to frontend
    • Compatibility to staging-frontend verified (running frontend locally in Docker container with image matching the deployed image on staging)

Marcel Scherrer added 20 commits April 23, 2022 22:35
create necessary classes
56825ef
adjust Interface PriceRepository
fadf505
setup Model for Price
8115d6a
define method structur for PriceService
6d6d517
implement PriceBody
095d480
setup structure for PriceController
d9b524c
setup structure for testclass
c8e666f
implement setup() for testing
749bca5
Merge branch 'main' of https://github.com/saunah/saunah-backend into …
eb5c33a 
…feature/priecing_sauna
setup test for addPrice() method
ca89cdd
tried to implement AddPrice => error
495d611
setup Test getPrice()
04c3e24
setup Test editPrice()
d2c65d8
setup Test removePrice()
3b49882
implement addPrice() methode
8775581
Merge branch 'main' of https://github.com/saunah/saunah-backend into …
8c8ad1d 
…feature/priecing_sauna
implement getPrice() methode
8c95b1b
implement editPrice() methode
7ed8fb3
implement removePrice() methode
2574469
clean up code and add Javadoc
3815bcc
@TG134516 TG134516 added the sprint 4 This issue is part of the fourth sprint label Apr 28, 2022
@TG134516 TG134516 requested a review from cabernin April 28, 2022 15:45
@cabernin
Copy link
Contributor

Add Restriction for Add/edit/remove api's in SaunahBackendApplication

cabernin
cabernin requested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@cabernin cabernin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht gut aus! 💪🎉
Es gibt aber noch ein paar Sachen, die man ändern muss -> Siehe Kommentare

@TG134516 TG134516 requested a review from cabernin April 29, 2022 10:50
cabernin
cabernin requested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@cabernin cabernin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Restriction for Add/edit/remove api's in SaunahBackendApplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

90.3% 90.3% Coverage
0.0% 0.0% Duplication

cabernin
cabernin approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@cabernin cabernin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist ok 🍻🚀

@cabernin cabernin merged commit 06ff9b8 into main Apr 29, 2022
@cabernin cabernin deleted the feature/priecing_sauna branch April 30, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabernin cabernin cabernin approved these changes

Assignees

@TG134516 TG134516

@cabernin cabernin

Labels
sprint 4 This issue is part of the fourth sprint
Projects
SauNah Scrum Bööööörd
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pricing backend
3 participants
@TG134516 @cabernin @NinoCabernard