Your encrypted storage can benefit from a binary encoding scheme

[xadaemon]

I would like to suggest at elara.elarautil.Util.encryptAndStore you use a binary encoding scheme like msgpack or to dump as json and encode as utf-8 and that will give you bytes to encrypt and then store while reliably being able to get the data back, the way it is right now you encode as ASCII (not compatible with utf-8 that might exist in the db) causing possible data loss, and saving the encoding to base64 round trip.

These are quite trivial changes, but I can help you implement them if you need help.
edit: also a hash/checksum to both encrypted and not ways might be a good idea.

[saurabh0719]

Hi @DarthUdp

Great catch there :)
I'd be happy to assign this issue to you if you want change the encoding to make it utf friendly.

The checksum however is already on its way, I'll release an update asap.

[xadaemon]

Do assign it then, it should be a quick fix

[saurabh0719]

@DarthUdp assigned it to you.

[xadaemon]

@saurabh0719 there are some formatting issues with the code, as a suggestion if you don't mind, there is a tool called black that will fix and make all the code consistently formatted.

[xadaemon]

And the docstrings at the files should be double quotes, sorry for the nitpicks :)

[saurabh0719]

And the docstrings at the files should be double quotes, sorry for the nitpicks :)

No problem, thanks for the tips :)

[saurabh0719]

@DarthUdp If you're still interested would you like to take up the checksum() function as well? I think you can do it with md5.hexdigest() from the hashlib library. I will probably shift my focus more towards formatting and fixing certain other issues that I have planned.

[xadaemon]

@saurabh0719 Just a side note, md5 is considered deprecated and should not be used anymore, also it's a hashing algorithm, a checksum is something like crc32, if doing hashes something like sha-256 should be used if doing checksums crc32 is a popular choice.

[xadaemon]

Just open another issue and assign me I will have a look when I have some spare time tomorrow

[saurabh0719]

@saurabh0719 Just a side note, md5 is considered deprecated and should not be used anymore, also it's a hashing algorithm, a checksum is something like crc32, if doing hashes something like sha-256 should be used if doing checksums crc32 is a popular choice.

Yes good point, I ended up reading a bit about crc

[saurabh0719]

Just open another issue and assign me I will have a look when I have some spare time tomorrow

I've opened a new issue, unable to assign it to you however (idk why), but I've mentioned you.