Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speaker name extraction doesn't consider more than one word. #1

Closed
saurabhshri opened this issue May 16, 2017 · 2 comments
Closed

Speaker name extraction doesn't consider more than one word. #1

saurabhshri opened this issue May 16, 2017 · 2 comments

Comments

@saurabhshri
Copy link
Owner

In case of single-word speaker name, the parser works fine, but in case there are more than one word, only last word is extracted.

Saurabh: Oompa Loompa is extracted as Oompa Loompa, while
Saurabh Shri: Oompa Loompa is extracted as Saurabh Oompa Loompa.

This is just a matter of searching till the start of statement / appearance of "\n".
saurabhshri referenced this issue May 20, 2017
@saurabhshri
Improving Speaker Name detection.
3f3e2a3 
Speaker Name detection on steroids :P :P
@saurabhshri
Copy link
Owner Author

Resolved in 3f3e2a3 .

@Jonathhhan
Copy link

Jonathhhan commented Mar 27, 2022 •
edited
Loading

I have a similar issue. For example getDialogue() MAN 1: Looks like a tie. becomes MAN: Looks like a tie. and it should become Looks like a tie.. And BLANEY: Rusk did it. doesnt change and should become: Rusk did it. And somehow your pull request above gives me a dublicate symbols error message. It would be great, if that is possible to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saurabhshri @Jonathhhan