Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last subtitle is "cloned" in an edge case #7

Closed
midn1 opened this issue Mar 16, 2018 · 2 comments
Closed

Last subtitle is "cloned" in an edge case #7

midn1 opened this issue Mar 16, 2018 · 2 comments

Comments

@midn1
Copy link

midn1 commented Mar 16, 2018 •
edited
Loading

Consider this subtitle file:

1
00:00:01,000 --> 00:00:01,500
Subtitle one

2
00:00:02,000 --> 00:00:02,500

(Note the two newlines before the EOF)
This causes the parser to clone the last subtitle, which creates an empty third subtitle.

Removing the second newline avoids this issue.
@midn1 midn1 changed the title Empty subtitle in an edge case Last subtitle is "cloned" in an edge case Mar 16, 2018
@saurabhshri
Copy link
Owner

Feel free to send a PR! :)

@saurabhshri saurabhshri mentioned this issue Oct 27, 2019
Closed
@saurabhshri
Copy link
Owner

Thanks for the report, tracking in #8 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@midn1 @saurabhshri