Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh: Also use the check command_name in the serie name #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enh: Also use the check command_name in the serie name #21

wants to merge 1 commit into from

Conversation

gst
Copy link
Contributor

@gst gst commented Apr 8, 2015

This will fix #20

@gst
Copy link
Contributor Author

gst commented Apr 8, 2015

NB:
required change in Shinken: https://github.com/gst/shinken/tree/enh_also_give_check_command_in_broks

@gst gst force-pushed the enh_use_check_command_name_in_serie_name branch from 5c1eec5 to 415a50b Compare April 8, 2015 21:22
@gst
Copy link
Contributor Author

gst commented Apr 8, 2015

pep8.. damn

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.88% when pulling 415a50b on enh_use_check_command_name_in_serie_name into 639665a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.88% when pulling 415a50b on enh_use_check_command_name_in_serie_name into 639665a on master.

@gst gst mentioned this pull request Apr 8, 2015
Open
@aviau
Copy link
Contributor

aviau commented Apr 9, 2015

Waiting for shinken-solutions/shinken#1564

@gst
Copy link
Contributor Author

gst commented Aug 10, 2015

don't know about the necessity of this but about :

Waiting for shinken-solutions/shinken#1564

this has been merged in .. gst/alignak@5478f7f

@aviau
Copy link
Contributor

aviau commented Aug 10, 2015

I would like or mod-influxdb to stay compatible with Shinken, as we have many shinken users. Is there a reason it was not merged in Shinken?

@gst
Copy link
Contributor Author

gst commented Aug 10, 2015

Is there a reason it was not merged in Shinken?

I had closed it cause' we moved out of that. But if you would like / need it you can reopen the PR, but the good one is this one : shinken-solutions/shinken#1592 , the other one was bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Also use the check command_name to store in series
3 participants
@gst @coveralls @aviau