Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USD currency support to RU language #211

Merged
merged 2 commits into from Oct 14, 2018

Conversation

MontakOleg
Copy link
Contributor

Changes proposed in this pull request:

Add support USD currency for RU language

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Run tests

tests/test_ru.py Outdated
)
self.assertEqual(
num2words('1234.56', lang='ru', to='currency', currency='USD'),
'одна тысяча двести тридцать четыре доллара, пятьдесят шесть центов'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing due to this line being bigger than 79 characters. Splitting it should fix the problem.

Copy link
Collaborator

@erozqba erozqba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, update your base branch to solve the conflicts.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 513

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.691%

Totals Coverage Status
Change from base Build 506: 0.0%
Covered Lines: 2471
Relevant Lines: 2755

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Oct 14, 2018

Pull Request Test Coverage Report for Build 513

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.691%

Totals Coverage Status
Change from base Build 506: 0.0%
Covered Lines: 2471
Relevant Lines: 2755

💛 - Coveralls

@MontakOleg
Copy link
Contributor Author

Ok, done!

@erozqba erozqba merged commit 9a31d90 into savoirfairelinux:master Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants