Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Korean support #219

Merged
merged 4 commits into from Nov 10, 2018
Merged

Add: Korean support #219

merged 4 commits into from Nov 10, 2018

Conversation

BayMinimum
Copy link
Contributor

Changes proposed in this pull request:

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Run the test cases in tests/test_ko.py

@coveralls
Copy link

Pull Request Test Coverage Report for Build 542

  • 63 of 68 (92.65%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 90.038%

Changes Missing Coverage Covered Lines Changed/Added Lines %
num2words/lang_KO.py 62 67 92.54%
Files with Coverage Reduction New Missed Lines %
num2words/compat.py 4 100.0%
Totals Coverage Status
Change from base Build 537: 0.06%
Covered Lines: 2603
Relevant Lines: 2891

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 542

  • 63 of 68 (92.65%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 90.038%

Changes Missing Coverage Covered Lines Changed/Added Lines %
num2words/lang_KO.py 62 67 92.54%
Files with Coverage Reduction New Missed Lines %
num2words/compat.py 4 100.0%
Totals Coverage Status
Change from base Build 537: 0.06%
Covered Lines: 2603
Relevant Lines: 2891

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 19, 2018

Pull Request Test Coverage Report for Build 544

  • 63 of 68 (92.65%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 90.038%

Changes Missing Coverage Covered Lines Changed/Added Lines %
num2words/lang_KO.py 62 67 92.54%
Files with Coverage Reduction New Missed Lines %
num2words/compat.py 4 100.0%
Totals Coverage Status
Change from base Build 537: 0.06%
Covered Lines: 2603
Relevant Lines: 2891

💛 - Coveralls

Copy link
Collaborator

@erozqba erozqba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BayMinimum Thanks a lot for this contribution!
Could you please add a couple of tests to cover the missing lines here https://coveralls.io/builds/19610397/source?filename=num2words%2Flang_KO.py#L123

num2words/lang_KO.py Outdated Show resolved Hide resolved
Added Korean language support and tests
@erozqba erozqba merged commit 4d8c938 into savoirfairelinux:master Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants