Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German improvements #237

Merged
merged 6 commits into from Jan 18, 2019
Merged

German improvements #237

merged 6 commits into from Jan 18, 2019

Conversation

zenogantner
Copy link
Contributor

Changes proposed in this pull request:

  • ordinals: "Million" etc. is written in upper case
  • cardinals: similar rule for 1 million etc. as for 100, 1000
  • cardinals: several millions etc. are written without space
  • add some more tests

Status

  • [X ] READY

How to verify this change

https://de.wikipedia.org/wiki/Million#Sprachliches

@coveralls
Copy link

coveralls commented Jan 13, 2019 •
edited

Pull Request Test Coverage Report for Build 613

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.605%
Totals Coverage Status
Change from base Build 612: 0.02%
Covered Lines: 4758
Relevant Lines: 5044
💛 - Coveralls

@kkonieczny kkonieczny merged commit 83cfcdc into savoirfairelinux:master Jan 18, 2019
@eortiz-tracktik eortiz-tracktik mentioned this pull request May 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkonieczny kkonieczny kkonieczny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zenogantner @coveralls @kkonieczny