Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert some copyright changes made in commit 53b4518 #254

Merged
merged 1 commit into from May 7, 2019
Merged

Revert some copyright changes made in commit 53b4518 #254

merged 1 commit into from May 7, 2019

Conversation

neysofu
Copy link
Contributor

@neysofu neysofu commented May 6, 2019

Commit 53b4518 made added explicit utf-8 encoding for all sources, among other things. A copyright notice in tests/test_tr.py was mistakenly removed and two were added in num2words/lang_it.py. I know this was a simple overlook, I just thought it would be best to explicitly give credit where credit is due.

Commit 53b4518 made added explicit utf-8 encoding for all sources, among
other things. A copyright notice in `tests/test_tr.py` was removed and
two were added in `num2words/lang_it.py`. I know this was a simple
mistake, I just thought it would be best to explicitly give credit where
credit is due.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 682

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.966%

Totals Coverage Status
Change from base Build 673: 0.0%
Covered Lines: 4877
Relevant Lines: 5155

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented May 6, 2019

Pull Request Test Coverage Report for Build 682

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.966%

Totals Coverage Status
Change from base Build 673: 0.0%
Covered Lines: 4877
Relevant Lines: 5155

💛 - Coveralls

@erozqba
Copy link
Collaborator

erozqba commented May 7, 2019

Thanks a lot @neysofu

@erozqba erozqba merged commit f6dc5a3 into savoirfairelinux:master May 7, 2019
@eortiz-tracktik eortiz-tracktik mentioned this pull request May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants