Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to base.py #283

Merged
merged 4 commits into from Dec 31, 2019
Merged

Conversation

williamjmorenor
Copy link
Contributor

@williamjmorenor williamjmorenor commented Oct 25, 2019

Signed-off-by: William José Moreno Reyes williamjmorenor@gmail.com

Fixes: #125

Changes proposed in this pull request:

Just more tests to improve coverage.

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

This pull request update test coverage of num2words/base.py to 92%

@coveralls
Copy link

coveralls commented Oct 25, 2019

Pull Request Test Coverage Report for Build 832

  • 17 of 18 (94.44%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
num2words/base.py 0 1 0.0%
Totals Coverage Status
Change from base Build 830: 0.2%
Covered Lines: 10078
Relevant Lines: 10444

💛 - Coveralls

Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Fix:
 - savoirfairelinux#125

Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
@erozqba erozqba merged commit 5fe8815 into savoirfairelinux:master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increment the test coverage for num2words/base.py
3 participants