Fix Hebrew support #289
Merged
Fix Hebrew support #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correct gender of 1 and 2 (and 11 and 12) to match remainder of numbers - Fix spelling of 8 (and 18 and 80) - Add cases for thousands 3-9 and support in the logic - Fix placement of "and" conjunction to match Academy of Hebrew Language position - Add tests
Pull Request Test Coverage Report for Build 778
💛 - Coveralls |
Pull Request Test Coverage Report for Build 777
💛 - Coveralls |
erozqba
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Hebrew by correcting spelling, gender, conjunction logic, thousands, and adds tests
Changes proposed in this pull request:
Status
How to verify this change
Aside from working knowledge of Hebrew, can run tests.