Polishordinals #367
Merged
Polishordinals #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1015
💛 - Coveralls |
|
@mromdhane |
|
@PaulinaKomorek Can you rebase/Squash commits into one please. I am reviewing it . |
PaulinaKomorek
force-pushed
the
polishordinals
branch
3 times, most recently
from
48b2806
to
a3f247f
Compare
|
@mromdhane Sorry, I am afraid I am not experienced enough in git, so I was unable to rebase it successfully, instead. I created a new commit with the proper message and all changes and force-pushed it into this branch. I hope that it is enough. |
|
Hello, @mromdhane any update on this topic? |
|
Hi @PaulinaKomorek Yes I check it, Can you merge master with your branch, please? |
PaulinaKomorek
force-pushed
the
polishordinals
branch
from
a3f247f
to
9dfdabf
Compare
|
@mromdhane Done. Thank you! |
mromdhane
approved these changes
Apr 23, 2021
KommuSoft
pushed a commit
to hapytex/num2words
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polish ordinals # by PaulinaKomorek
Changes proposed in this pull request:
Status
How to verify this change
unit tests cover all of the possible cases
Additional notes
-