New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES] Added missing accents ("dieciséis", "dólar", "dólares", "veintiún"), improved currency gender handling, fixed pound cent names #443
Conversation
…es); fixed accents in test_es.py (dieciséis, dólar, dólares, veintiún)
Fixed: ./num2words/lang_ES.py:366:56: E261 at least two spaces before inline comment ./num2words/lang_ES.py:366:80: E501 line too long (100 > 79 characters)
Hi @erozqba, I think this pull request would need a review but I'm not sure who to ask. I think this is a small but useful fix for Spanish, since it fixes the orthography of a basic number (16, from "dieciseis" to "dieciséis"), along with a few other accent-related orthography fixes. I've followed the steps in CONTRIBUTING, and I can take any additional steps I might have missed. |
@gonsalet I think your changes are good! I don't know why the test and coveralls have not run and the new maintainers at Savoir Faire Linux removed me from the list of reviewers with write access, so I cannot approve your PR. 😭 |
Thanks @erozqba! I guess I'll try to contact Savoir Faire Linux to see if a current maintainer can check this. |
@support-savoirfairelinux anyone who could review this pull request? Thanks! |
Fixed accent in Spanish examples ("centimos"->"céntimos"), thus making the example consistent with actual current behaviour.
@mromdhane anyone who could review this pull request? Thanks! |
Fixed accent in Spanish command line examples ("centimos"->"céntimos"), thus making the example consistent with actual current behaviour.
@mrodriguezg1991 anyone who could review this pull request? I guess there's a lot of maintenance to be done on this project, so I understand that this pull request might not be high priority, but I'm around in case this pull requires any additional steps. Thanks in any case! |
@gonsalet There are some issues with the CI to be able to merge new pull request, I am currently waiting for access in order to be able to maintain the project, as soon as all the issues are solved, i will be working on answering all requests. |
…test_es: updated accordingly
Pull Request Test Coverage Report for Build 2698520765
💛 - Coveralls |
Fixes #444, #449 by gonsalet
Changes proposed in this pull request:
Status
How to verify this change
Additional notes
This PR includes the fixes proposed in currently open pull request #291 by @ekbrown
The added accents are the correct orthography. These words were not correct without the added accents. Orthography checked against official Diccionario de la lengua española ( https://dle.rae.es/ ).
The pound cents "penny" and "pence" were untranslated or inconsistently translated in several parts of the code. Checked that the correct "penique" and "peniques" are now used throughout.
Feminine currency handling is now correct, with independent handling of the "dollars" part and the "cents" part of the currency. Rules checked against official Diccionario panhispánico de dudas ( https://www.rae.es/dpd/una , section 2.2 ).
Pull request checklist
General
Can the branch be merged automatically? Yes.
Testing
Do the unit tests pass? Yes.
Adding new code
Is the code PEP8 compliant? Yes.
Is the code covered by tests? Yes.