Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLS CRASH - no EXTM3U delimiter #3284

Closed
loan-talvat opened this issue Aug 1, 2023 · 2 comments · Fixed by #3286
Closed

HLS CRASH - no EXTM3U delimiter #3284

loan-talvat opened this issue Aug 1, 2023 · 2 comments · Fixed by #3286

Comments

@loan-talvat
Copy link

We are using Liquidsoap in Azuracast, and we have an issue for HLS with Liquidsoap
Here is the detail of the error encountered: AzuraCast/AzuraCast#6184

Is it possible to fix this problem?

@vitoyucepi
Copy link
Collaborator

Summary

Occasionally output.harbor.hls and output.file.hls can output incomplete files.

Reproduction

output.harbor.hls([("mp3", %mp3)], sine(), segment_duration=0.01, segments=1000)
while true;do curl -s http://localhost:8000/mp3.m3u8 | wc -l;done
2005
2005
0
2005
2005

Versions

Liquidsoap: 2.0.7, 2.1.4, 2.2.0

Install method

Container image: savonet/liquidsoap

@toots
Copy link
Member

toots commented Aug 1, 2023

Thanks for reporting. This is addressed with #3286 which I'll merge as soon as it's been properly tested.

Although this breaks the even API, I think that this is a good candidate for a rolling-release backport.

If y'all need a workround, it's possible to used a separate folder for nginx serving and use the (soon to be deprecated) "closed" event to move files when they are done writting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants