Drop default on_fail. #3479
Merged
Drop default on_fail. #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toots
force-pushed
the
drop-default-on-fail
branch
from
57a2204
to
bcfb0ca
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
toots
added a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops
on_faildefault behavior or reloading playlist inplaylistin case of failure.The reason is that, directory playlists are likely to contain invalid files (for instance the infamous
.DS_Storeon macos). In cases like that, we end up with infinite reloading loops.