Thread safety

[minad]

HTTPI doesn't seem to be thread safe because of global state. This is bad :(

Also related to #73

[rubiii]

could you describe your problem or perhaps even provide code/specs to reproduce it?

[minad]

The adapter object is shared globally. If you use HTTPI from multiple threads it won't work.

[rubiii]

we still need a spec to verify a potential fix. i think @rogerleite was planning to work on adapters after his holidays.
so a failing spec for this could help redesign the current adapter implementation.

[minad]

This is obvious from the design. Maybe it would be better to redesign the library somehow, to allow persistent connections etc. and make it thread safe.

client = HTTPI.new
client.get
...
client.close

One could still provide convenience methods HTTPI.get etc which have the overhead that they always create a new HTTPI instance each time.

[minad]

I looked again at your code more carefully - no I am not so confused anymore. The adapter isn't shared as it seemed to me before, so no problem. But I still wonder why do you not have a HTTPI::Client class. Then would could also implement persistent connections.

[rubiii]

because it's simply not that easy to support. see #41

[minad]

Ah ok! Maybe drop the backends which don't support such a design...