Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why add Hash#to_params #65

Closed
jcoleman opened this issue Sep 24, 2014 · 1 comment
Closed

Why add Hash#to_params #65

jcoleman opened this issue Sep 24, 2014 · 1 comment

Comments

@jcoleman
Copy link

Is there a particularly reason by Nori defines Hash#to_params (and related methods)? This method doesn't seem to be used anywhere inside Nori or Savon, it's not in the README, and it doesn't seem to be related to XML parsing.

I'm wondering in particular because I have pull request into Rails with defines Hash#to_params (with a different meaning) since Rails already defines Hash#to_param with the same basic meaning as what to_params does in this project.

@tjarratt
Copy link
Contributor

tjarratt commented Feb 9, 2015

Hey @jcoleman -- sorry this took me so dang long to respond to. If I had to wager a guess, by looking at the older refs that changed that file, I would say that this came in from Nori being a fork of Crack.

You're absolutely right that Nori and Savon are not using it. Thanks for pointing this out. I just removed the extension in commit 4db35be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants