Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Nested Body Attributes To Be Set #949

Open
davidahopp opened this issue Feb 2, 2021 · 1 comment
Open

Allow Nested Body Attributes To Be Set #949

davidahopp opened this issue Feb 2, 2021 · 1 comment
Labels

Comments

@davidahopp
Copy link

davidahopp commented Feb 2, 2021

Feature request

Motivation for this feature:

Working on pulling data from a providers system: https://ot.dms.dealertrack.com/partsapi.asmx?WSDL, I am unable to added a nested field object as they are directing me to and they are not defining it correctly in their WSDL so that it automatically is set.

Proposed implementation:

I would like to be able to make a call like this:

Savon.client("https://ot.dms.dealertrack.com/partsapi.asmx?WSDL", nil).call(operation_name, {attributes: {PartsSalesHistory: {SalesHistoryParms: {xmlns:"opentrack.dealertrack.com/transitional"}}}, message: payload})

and then have it generate the following XML (this is just the body as a note):

 <soap:Body>
   <PartsSalesHistory>
     <Dealer>
       <EnterpriseCode>val</EnterpriseCode>
       <CompanyNumber>val2</CompanyNumber>
       <ServerName>val3</ServerName>
     </Dealer>
     <SalesHistoryParms xmlns="opentrack.dealertrack.com/transitional">
       <DateStart>20200101</DateStart>
       <DateEnd>20200102</DateEnd>
     </SalesHistoryParms>
   </PartsSalesHistory>
 </soap:Body>

If this is something I need to tell the provider to fix their WSDL, could you provide recommendations on what I need to tell them as I do not have much experience in XML and WSDL.

Would this introduce a breaking change? I hope not

Are you willing to work on this yourself?
I do not currently have a lot of free time but maybe.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant