Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router.errorView is not effected when a router was created by calling router.NewGroupPath() #51

Closed
cyannuk opened this issue Nov 11, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@cyannuk
Copy link

cyannuk commented Nov 11, 2019

Easy fix

diff --git a/router.go b/router.go
index 9b5c5e3..e7550d4 100644
--- a/router.go
+++ b/router.go
@@ -38,6 +38,7 @@ func (r *Router) NewGroupPath(path string) *Router {
 	g.router = r.router.Group(path)
 	g.parent = r
 	g.beginPath = path
+	g.errorView = r.errorView
 
 	return g
 }
@savsgio
Copy link
Owner

savsgio commented Nov 12, 2019

I will have the pleasure to accept your PR if you want 😄

If not that's it, I will fix it.

@savsgio savsgio added the bug Something isn't working label Nov 12, 2019
@savsgio savsgio closed this as completed Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants