Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Graceful Restart and Auto-Update #56

Closed
kokizzu opened this issue Dec 14, 2019 · 6 comments
Closed

Feature Request: Graceful Restart and Auto-Update #56

kokizzu opened this issue Dec 14, 2019 · 6 comments

Comments

@kokizzu
Copy link

kokizzu commented Dec 14, 2019

Similar to what overseer do

@savsgio
Copy link
Owner

savsgio commented Dec 14, 2019

Hi @kokizzu ,

I couldn't see the link!

What do you need exactly?

@savsgio
Copy link
Owner

savsgio commented Dec 14, 2019

Graceful restart must be implemented on top of atreugo, because Go must be recompiled if code change.

So you could use the Reuseport for run two server instances (old and new) in the same port without hold to server requests and kill the old version, but this implementation must be out of framework, because i couldn't know the best way for each case.

And for Auto-update, what do you mean?

@savsgio
Copy link
Owner

savsgio commented Dec 14, 2019

Please see: #39 (comment)

@kokizzu
Copy link
Author

kokizzu commented Dec 15, 2019

i fixed the link, auto update replaces binary and restart the server when there's a new update

@savsgio
Copy link
Owner

savsgio commented Dec 17, 2019

You could implement these features without matters with overseers or similars libs.

I prefer to not include it, by reasons that i gave you and because they are include some complexity to the framework that is not responsability of Atreugo.

Thanks equally. 😃

@savsgio savsgio closed this as completed Dec 17, 2019
@savsgio
Copy link
Owner

savsgio commented Dec 17, 2019

Maybe, in the future, I can consider doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants