Update scrollbar on ClientCreate and WinResize #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it so the scrollbar is shown immediately when opening a file, and also when reconnecting to an older window.
|
Wait, it looks like the Edit: mawww/kakoune#4234 |
|
Thanks for pointing that out—it's essential functionality. And thanks for the appreciation! Right then, let's have a go at making all these changes work together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientCreate: The scrollbar wouldn't show on a new window until pressing a key (triggeringRawKey) with onlyWinCreate. Updating on the window'sClientCreateinstead of updating the scrollbar immediately inscrollbar-enablefixes this issue. Basically the window waits for a terminal to connect to it before updating it.WinResizeshould be self-explanatory ;PThank you for making scrollbar.kak!