Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetStandard 2.0 #4

Closed
kfrancis opened this issue May 3, 2018 · 6 comments
Closed

Add NetStandard 2.0 #4

kfrancis opened this issue May 3, 2018 · 6 comments

Comments

@kfrancis
Copy link
Contributor

kfrancis commented May 3, 2018

Hey,

Question - I'd like to add NetStandard support for your library. I've already done all the work to add multi-targeting to your library. Would you be ok with that pull request? The actual change is simple, I did have to reconfigure the test project but all tests are passing in both full .NET Framework and .NET Core now.

@SaxxonPike
Copy link
Owner

This sounds great! Put in the request and I'll look it over. Thanks for your efforts :)

@SaxxonPike
Copy link
Owner

The latest commit should add this to the list of targeted frameworks. There will need to be further work to bring the test project's NUnit up to 3 so that we can also run the tests on .NET Standard 2.0. However, as-is, the library compiles for both .NET 4.5 and .NET Standard 2.0.

@kfrancis
Copy link
Contributor Author

I can do that, sorry for the delay.

kfrancis added a commit to kfrancis/NextLevelSeven that referenced this issue Oct 15, 2018
@kfrancis
Copy link
Contributor Author

If you do end up accepting that pull request, would you mind pushing it out to nuget pretty please?

SaxxonPike added a commit that referenced this issue Oct 17, 2018
@SaxxonPike
Copy link
Owner

Going to put this out as 1.0.1. For long story reasons.

@SaxxonPike
Copy link
Owner

@kfrancis It looks like this was approved and indexed, and there are some downloads already. So, I'm going to assume all is well. If any further issues crop up, let's reopen new issues more appropriate to whatever's up. Thanks for everything!

It has been published at:
https://www.nuget.org/packages/NextLevelSeven/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants