Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suffusion and PHP 7.3 #4

Closed
mbrsolution opened this issue May 16, 2019 · 2 comments
Closed

Suffusion and PHP 7.3 #4

mbrsolution opened this issue May 16, 2019 · 2 comments

Comments

@mbrsolution
Copy link

mbrsolution commented May 16, 2019

Hi, I decided to test Suffusion with PHP 7.3 and WordPress 5.2. It works okay but with the following warnings. However I have not thoroughly tested all functionality of Suffusion yet.

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 666

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 671

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 684

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 689

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in D:\webserver\xampp7-3\htdocs\mbrlocal\wp-content\themes\suffusion\functions\media.php on line 694

Kind regards

@Ciprian-Dracea
Copy link
Collaborator

Ciprian-Dracea commented May 20, 2019

Hi Manuel,

I committed all changes from past years in this repository and I corrected the media.php file to avoid these warnings. The new version of theme - 4.5.6. - can be downloaded from "dist" folder.

Please check the new version and close the issue if everything is OK.

Thank you for reporting,
Drake

@mbrsolution
Copy link
Author

Hi Drake,

Well done, your patch works well. That makes me very happy because it keeps the theme alive :)

I will keep doing more testing with PHP 7.3 and WordPress 5.2. I will report it here in a new support ticket if I find more issues.

Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants