Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug on sequential data #124

Closed
susie-ku opened this issue Sep 8, 2023 · 2 comments · Fixed by #123
Closed

Bug on sequential data #124

susie-ku opened this issue Sep 8, 2023 · 2 comments · Fixed by #123
Assignees
@susie-ku @D1MK4real
Labels
bug Something isn't working

Comments

@susie-ku
Copy link
Collaborator

susie-ku commented Sep 8, 2023

Wrong logic in conditions
Correct both for numeric and categoric features
cat: https://github.com/sb-ai-lab/LightAutoML/blob/0bcbb8523b499e27eea493eca1d44b247b42e4b0/lightautoml/ml_algo/dl_model.py#L316C22-L316C22
cont:

LightAutoML/lightautoml/ml_algo/dl_model.py

Line 303 in 0bcbb85

"cont_embedder_": cont_embedder_by_name.get(params["cont_embedder"], LinearEmbedding)

To reproduce: for Autoint and FTTransformer set use_cat to False, advanced_roles to False and all features to numeric
@susie-ku susie-ku added the bug Something isn't working label Sep 8, 2023
@susie-ku
Copy link
Collaborator Author

susie-ku commented Sep 8, 2023

Add missing default embedders to seq embedders

LightAutoML/lightautoml/ml_algo/dl_model.py

Line 113 in 0bcbb85

cat_embedder_by_name_flat = {

@D1MK4real D1MK4real linked a pull request Sep 8, 2023 that will close this issue
Bugfixes #123
Merged
@D1MK4real
Copy link
Collaborator

Done.

@susie-ku susie-ku closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susie-ku susie-ku

@D1MK4real D1MK4real

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfixes sb-ai-lab/LightAutoML
2 participants
@susie-ku @D1MK4real