Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save button doesn't work #3

Closed
setanarut opened this issue Dec 26, 2020 · 11 comments
Closed

save button doesn't work #3

setanarut opened this issue Dec 26, 2020 · 11 comments

Comments

@setanarut
Copy link
Contributor

Ekran Resmi 2020-12-27 00 49 31

Ekran Resmi 2020-12-27 00 49 02

@sbarex
Copy link
Owner

sbarex commented Dec 26, 2020

The extension inline local images is on?

@setanarut
Copy link
Contributor Author

Yes, I found the problem. When I relaunch finder, the permission dialog appeared and was fixed. the save button does not work. After restarting finder, the settings are applied.

@setanarut setanarut reopened this Dec 26, 2020
@setanarut setanarut changed the title local images doesn't work save button doesn't work Dec 26, 2020
@sbarex
Copy link
Owner

sbarex commented Dec 26, 2020

MacOS handle the preferences with a cache system.
Perhaps by restarting the Finder they had not had time to save themselves?

@setanarut
Copy link
Contributor Author

MacOS handle the preferences with a cache system.
Perhaps by restarting the Finder they had not had time to save themselves?

I don't know. Also, there is currently no way to know if the settings are saved or applied. (Nothing happens when the save button is clicked.)

@sbarex
Copy link
Owner

sbarex commented Dec 26, 2020

When you make a change on the settings, the red close window button show the dirty status. if the save is successful the dirty status will be reset.

@setanarut
Copy link
Contributor Author

When you make a change on the settings, the red close window button show the dirty status. if the save is successful the dirty status will be reset.

this is top secret. You should put a label that says "saved. or it can be a flash effect like TextEdit"

Ekran.Kaydi.2020-12-27.01.45.47.mov

@setanarut
Copy link
Contributor Author

Also save menu always disabled
Ekran Resmi 2020-12-27 01 44 55

@sbarex
Copy link
Owner

sbarex commented Dec 26, 2020

ahah, yes it's not very intuitive.
The menu action is not linked to the action of the button... new release will fix it.

@relikd
Copy link
Contributor

relikd commented Dec 27, 2020

The changes are reflected even without a Finder restart but it takes more time. It was nearly one minute on my machine at one point. But like @sbarex said some caching issues. Maybe there is a way to tell macOS to force prune the cache?

@relikd
Copy link
Contributor

relikd commented Dec 27, 2020

@hazarek thats not fair. The app is still very early stage. If you don't like how it works propose a PR to fix it. But don't badmouth the time and effort someone puts into this in their free time.

@setanarut
Copy link
Contributor Author

@hazarek thats not fair. The app is still very early stage. If you don't like how it works propose a PR to fix it. But don't badmouth the time and effort someone puts into this in their free time.

You are right sorry. I'm just so excited. @sbarex sorry. Thanks for the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants