Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sbb-tag, sbb-tag-group): add size s variant #2664

Merged
merged 13 commits into from
Jun 3, 2024
Merged

feat(sbb-tag, sbb-tag-group): add size s variant #2664

merged 13 commits into from
Jun 3, 2024

Conversation

dauriamarco
Copy link
Contributor

Closes #2625

@dauriamarco dauriamarco added pr: peer review required A peer review is required for this pull request pr: ux review required A ux review is required for this pull request labels May 16, 2024
@dauriamarco dauriamarco self-assigned this May 16, 2024
jeripeierSBB
jeripeierSBB requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

src/components/tag/tag/tag.spec.ts Outdated Show resolved Hide resolved
src/components/tag/tag-group/__snapshots__/tag-group.spec.snap.js Outdated Show resolved Hide resolved
src/components/tag/tag/readme.md Outdated Show resolved Hide resolved
src/components/tag/tag/tag.scss Outdated Show resolved Hide resolved
src/components/tag/tag/tag.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr2664 May 24, 2024 09:35 Inactive
@github-actions github-actions bot temporarily deployed to pr2664 May 30, 2024 08:20 Inactive
@mcilurzo mcilurzo added pr: ux review approved Pull request has been approved by a ux review and removed pr: ux review required A ux review is required for this pull request labels May 30, 2024
jeripeierSBB
jeripeierSBB approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/elements/tag/tag/tag.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 3, 2024
@dauriamarco dauriamarco merged commit 6291bdc into main Jun 3, 2024
21 of 22 checks passed
@dauriamarco dauriamarco deleted the feat/tag-size-s branch June 3, 2024 09:27
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 3, 2024
@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Merged
@mcilurzo mcilurzo added this to the Release 2.0.0 milestone Jun 14, 2024
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 25, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcilurzo mcilurzo mcilurzo left review comments

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

Assignees

@dauriamarco dauriamarco

Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available
Projects
ESTA Web Lyne Design System
Archived in project
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.

lean: tag: size S
3 participants
@dauriamarco @jeripeierSBB @mcilurzo