Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sbb-image): render URL correctly with SSR #2712

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix(sbb-image): render URL correctly with SSR #2712

merged 3 commits into from
Jun 5, 2024

Conversation

kyubisation
Copy link
Contributor

Closes #2690

@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jun 4, 2024
@github-actions github-actions bot temporarily deployed to pr2712 June 4, 2024 15:14 Inactive
jeripeierSBB
jeripeierSBB approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I like that we can save it in a test now :-)

src/elements/image/image.ssr.spec.ts Outdated Show resolved Hide resolved
src/elements/image/image.ts Show resolved Hide resolved
@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jun 5, 2024
kyubisation and others added 2 commits June 5, 2024 07:42
@kyubisation @jeripeierSBB
fix: review
d04adc9 
Co-authored-by: Jeri Peier <jeremias.peier@sbb.ch>
@kyubisation @jeripeierSBB
fix: review
19a4290 
Co-authored-by: Jeri Peier <jeremias.peier@sbb.ch>
@kyubisation kyubisation merged commit fde1700 into main Jun 5, 2024
20 of 22 checks passed
@kyubisation kyubisation deleted the fix-image-ssr branch June 5, 2024 06:32
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Jun 5, 2024
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Closed
This was referenced Jun 25, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeripeierSBB jeripeierSBB jeripeierSBB approved these changes

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: visual review required preview-available
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: SSR issue with sbb-image
2 participants
@kyubisation @jeripeierSBB