fix: ensure slotchange events are handled correctly in hydration #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: peer review required
kyubisation
force-pushed
the
fix-hydration-slotchange
branch
from
f1a12de
to
69b8c9d
Compare
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
jeripeierSBB
approved these changes
Jun 27, 2024
github-actions
bot
added
the
pr: lead review approved
github-actions
bot
added
pr: peer review required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly changes how we handled slotchange events during hydration. Previously we would stop slotchange events during hydration and re-dispatch them afterwards. However, it seems that during true page load with server side rendering, slotchange events are not dispatched at all. So we changed the logic to just generally suppress slotchange events during hydration and manually dispatch a slotchange event, for any slot having content assigned, after the hydration is finished.